Ticket #2395: fix-2395.dpatch

Fri Aug  7 11:48:41 PDT 2009  Alexander Dunlap <alexander.dunlap@gmail.com>
  * FIX #2395 (ViewPatterns trigger bad Check errors)

New patches:

[FIX #2395 (ViewPatterns trigger bad Check errors)
Alexander Dunlap <alexander.dunlap@gmail.com>**20090807184841
 Ignore-this: af83dc1d93b735bd89d5f9dcb2f5ca6b
] {
hunk ./compiler/deSugar/Check.lhs 112
 
 check :: [EquationInfo] -> ([ExhaustivePat], [EquationInfo])
        -- Second result is the shadowed equations
-check qs = (untidy_warns, shadowed_eqns)
+  -- if there are view patterns, just give up - don't know what the function is
+check qs | has_view_pattern = ([],[])
+         | otherwise = (untidy_warns, shadowed_eqns)
       where
hunk ./compiler/deSugar/Check.lhs 116
+        is_view x = hasViewPat x
+        has_view_pattern = any (\(EqnInfo p _) -> any is_view p) qs
        (warns, used_nos) = check' ([1..] `zip` map simplify_eqn qs)
        untidy_warns = map untidy_exhaustive warns 
        shadowed_eqns = [eqn | (eqn,i) <- qs `zip` [1..], 
hunk ./compiler/deSugar/Check.lhs 225
    | literals     = split_by_literals qs
    | constructors = split_by_constructor qs
    | only_vars    = first_column_only_vars qs
--- FIXME: hack to get view patterns through for now
-   | otherwise    = ([([],[])],emptyUniqSet)
 -- pprPanic "Check.check': Not implemented :-(" (ppr first_pats)
   where
      -- Note: RecPats will have been simplified to ConPats
hunk ./compiler/hsSyn/HsPat.lhs 28
 
        isBangHsBind, hsPatNeedsParens,
        patsAreAllCons, isConPat, isSigPat, isWildPat,
-       patsAreAllLits, isLitPat, isIrrefutableHsPat
+       patsAreAllLits, isLitPat, isIrrefutableHsPat, hasViewPat
     ) where
 
 import {-# SOURCE #-} HsExpr           (SyntaxExpr, LHsExpr, pprLExpr)
hunk ./compiler/hsSyn/HsPat.lhs 372
 
 The 1.3 report defines what ``irrefutable'' and ``failure-free'' patterns are.
 \begin{code}
+hasViewPat :: Pat id -> Bool
+hasViewPat p = hasViewPat' (L undefined p)
+
+hasViewPat' :: LPat id -> Bool
+hasViewPat' (L _ p) = go p where
+  go (WildPat _) = False
+  go (VarPat _) = False
+  go (VarPatOut _ _) = False
+  go (LazyPat p) = hasViewPat' p
+  go (AsPat _ p) = hasViewPat' p
+  go (ParPat p) = hasViewPat' p
+  go (BangPat p) = hasViewPat' p
+  go (ListPat p _) = any hasViewPat' p
+  go (TuplePat p _ _) = any hasViewPat' p
+  go (PArrPat p _) = any hasViewPat' p
+  go (ConPatIn _ p) = go' p
+  go (ConPatOut _ _ _ _ p _) = go' p
+  go (ViewPat _ _ _) = True
+  go (QuasiQuotePat _) = False
+  go (LitPat _) = False
+  go (NPat _ _ _) = False
+  go (NPlusKPat _ _ _ _) = False
+  go (TypePat _) = False
+  go (SigPatIn p _) = hasViewPat' p
+  go (SigPatOut p _) = hasViewPat' p
+  go (CoPat _ _ _) = False
+  go' p = case p of
+    PrefixCon ps -> any hasViewPat' ps
+    RecCon (HsRecFields fs _) -> any (hasViewPat' . hsRecFieldArg) fs
+    InfixCon p1 p2 -> hasViewPat' p1 || hasViewPat' p2
+
 isWildPat :: Pat id -> Bool
 isWildPat (WildPat _) = True
 isWildPat _           = False
}

Context:

[Windows build fix
Simon Marlow <marlowsd@gmail.com>**20090803144931
 Ignore-this: c066b5b75e58f3c4389fc199f700dce5
] 
[rts_stop_on_exception is a C int, not a W_
Simon Marlow <marlowsd@gmail.com>**20090803124916
 Ignore-this: d0432287956e7291a503a554424d6897
 amazing this hasn't caused any problems before now
] 
[Fix #3412: the worker of an Id might not be a local Id
Simon Marlow <marlowsd@gmail.com>**20090803112803
 Ignore-this: c433025fd02c997a05555f5c7e6a6a7b
] 
[Add -r option to darcs-all, and remove push-all (#3375)
Simon Marlow <marlowsd@gmail.com>**20090803104413
 Ignore-this: 6871c15294113898902be90210d9a7a9
 Contributed by: seliopou@gmail.com
     
 This patch modifies darcs-all to have feature parity with push-all by
 recognizing two new options.
 
     * -i, equivalent to --ignore-failure in push-all
     * -r <repo>, specifies the remote repository darcs commands will use
 
 Some example commands:
 
 Get the libraries from a repository of your choosing. This is useful
 when working with a git mirror:
 
     $ ./darcs-all -r http://darcs.haskell.org get
 
 Pull changes. Used to be:
 
     $ ./push-all --pull http://darcs.haskell.org
 
 Is now:
 
     $ ./darcs-all -r http://darcs.haskell.org pull
 
 Or to use the default remote of the ghc repository:
 
     $ ./darcs-all pull
] 
[remove dead code
Simon Marlow <marlowsd@gmail.com>**20090620214113
 Ignore-this: 6da2bda8efd2dc63c8931243ab7dec0a
] 
[fix warnings
Simon Marlow <marlowsd@gmail.com>**20090729134348
 Ignore-this: 98128ac0b78d861439ebf807af1ca417
] 
[Implement "ghc --abi-hash M1 M2 ..."
Simon Marlow <marlowsd@gmail.com>**20090729132125
 Ignore-this: d0a71b2fadefdfdefa6d287d28bad40f
 This prints a combined hash of the ABIs exposed by the modules listed
 on the command line.  It will be used by Cabal for generating a
 package Id based on the actual ABI of a package.
] 
[Clean GMP properly; fixes #3411
Ian Lynagh <igloo@earth.li>**20090802195759] 
[Fix permissions when installing
Ian Lynagh <igloo@earth.li>**20090802161237] 
[Fix creation of library doc index, and put the library docs in bindists
Ian Lynagh <igloo@earth.li>**20090802114202] 
[Remove a TODO item that's been done
Ian Lynagh <igloo@earth.li>**20090802103944] 
[Add a publish-docs rule
Ian Lynagh <igloo@earth.li>**20090801224155] 
[Add docs to bindists
Ian Lynagh <igloo@earth.li>**20090801222551] 
[Fix "make show" in a bindist
Ian Lynagh <igloo@earth.li>**20090801212604] 
[Make the new build system install the documentation
Ian Lynagh <igloo@earth.li>**20090801204624] 
[whitespace tweaks in rules/docbook.mk
Ian Lynagh <igloo@earth.li>**20090801195221] 
[Fix configure when alex/happy are installed to a directory containing spaces
Ian Lynagh <igloo@earth.li>**20090801182817] 
[Allow more than 64k instructions in a BCO; fixes #789
Ian Lynagh <igloo@earth.li>**20090801153203] 
[If ghci runs out of labels, panic
Ian Lynagh <igloo@earth.li>**20090801132829] 
[Fix the 64k insns overflow check in ghci, and add more checks
Ian Lynagh <igloo@earth.li>**20090801130014] 
[Fix cleaning the integer package
Ian Lynagh <igloo@earth.li>**20090730143129] 
[Fix warnings when building with the HEAD
Ian Lynagh <igloo@earth.li>**20090730143031] 
[Remove some redundant fromIntegral's
Ian Lynagh <igloo@earth.li>**20090730105532] 
[Fix space problems in ghci
Ian Lynagh <igloo@earth.li>**20090730105351
 We were making arrays with range (0, n-1) which is bad if n == 0 now
 that we are using Word types.
] 
[Make the types we use when creating GHCi bytecode better match reality
Ian Lynagh <igloo@earth.li>**20090729130911
 We were keeping things as Int, and then converting them to Word16 at
 the last minute, when really they ought to have been Word16 all along.
] 
[Add an (Outputable Word16) instance
Ian Lynagh <igloo@earth.li>**20090728134436] 
[Fix whitespace in ByteCodeAsm.lhs
Ian Lynagh <igloo@earth.li>**20090728123444] 
[Add CHECK(p), like ASSERT(p) but works even when !defined(DEBUG)
Simon Marlow <marlowsd@gmail.com>**20090729075433
 Ignore-this: a723f456e4b1eaeaa617a675da276aa2
 For inexpensive assertions
] 
[enable the x86-specific versions of atomic_inc()/atomic_dec()
Simon Marlow <marlowsd@gmail.com>**20090729075307
 Ignore-this: a271b7ade5502ec4d8444aac19f4b4c3
] 
[fix warning
Simon Marlow <marlowsd@gmail.com>**20090728103855
 Ignore-this: ee626aa5de0a2aed8f44ae1131cc341d
] 
[fix warning
Simon Marlow <marlowsd@gmail.com>**20090728102707
 Ignore-this: ad4f07a163921d17d242a9452b4bb578
] 
[fix a warning
Simon Marlow <marlowsd@gmail.com>**20090728101731
 Ignore-this: 73ead0a0004723757c0a51b56681c991
] 
[Be a bit more sensible about choosing external OccNames
Simon Marlow <marlowsd@gmail.com>**20090728100434
 Ignore-this: 4adcd661e76440deb2b4ab498ebd2d1e
 
 Instead of chr_$wchr, we now just get $wchr.  In general, when an
 OccName is system-generated, we leave it out of the final external
 name, preferring to use the name of the exported parent instead (which
 is necessarily a user-written name).
 
 Names should be no less deterministic, but should be shorter and more
 readable.
] 
[Remove old 'foreign import dotnet' code
Simon Marlow <marlowsd@gmail.com>**20090727144524
 Ignore-this: 821ebea2c3897415195318f107421472
 It still lives in darcs, if anyone wants to revive it sometime.
] 
[remove a couple of ToDos
Simon Marlow <marlowsd@gmail.com>**20090727094719
 Ignore-this: ef00fc481821dff4381ba9efcd792708
] 
[buildinfo files need a $$(wildcard)
Simon Marlow <marlowsd@gmail.com>**20090727091012
 Ignore-this: b4c3201dfa81fef32ee254dd9c955b2d
] 
[Slight tweak to avoid overflowing the command-line size in bindist
Simon Marlow <marlowsd@gmail.com>**20090727090946
 Ignore-this: 1e2ff207d03fed08576ac59f0b46c08c
 Not a real fix: if this bites us again we'll have to rethink
] 
[avoid (benign) error about overriding rules for binary-dist
Simon Marlow <marlowsd@gmail.com>**20090727090903
 Ignore-this: ffb7f7bf1290f2faf96ac177f76a1422
] 
[Give a better error message for hidden packages when building Cabal package
Ian Lynagh <igloo@earth.li>**20090726194915
 Fixes #3168
] 
[Add a -fbuilding-cabal-package flag
Ian Lynagh <igloo@earth.li>**20090726181934
 This means GHC knows whether it's building a Cabal package, or just
 Haskell sources. For example, it may wish to give different error
 messages when building a Cabal package.
] 
[Add an extension to disable n+k patterns
Ian Lynagh <igloo@earth.li>**20090725134703] 
[Fix a warning on Windows
Ian Lynagh <igloo@earth.li>**20090724221244] 
[Remove GHC's haskell98 dependency
Ian Lynagh <igloo@earth.li>**20090724210825] 
[add number of bytes to +RTS -DS leak reports
Simon Marlow <marlowsd@gmail.com>**20090724150010
 Ignore-this: 3a66585c8fd2b58ce96abab1e154fb6e
] 
[free the gc_thread structures during shutdown
Simon Marlow <marlowsd@gmail.com>**20090724145956
 Ignore-this: 25efeb189cbfb549af4550d266604f0e
] 
[Add atomic_inc()/atomic_dec(), and use them to replace gc_running_mutex
Simon Marlow <marlowsd@gmail.com>**20090724142620
 Ignore-this: d775eeaf85fd0f9064d87a0909134bc0
 This also fixes a memory leak on Windows with -threaded, because we
 were calling initMutex(&gc_running_mutex) for each GC, which allocates
 memory.
] 
[Rewrite the foreign import string parser using ReadP
Simon Marlow <marlowsd@gmail.com>**20090723152138
 Ignore-this: 1c7db770a29d48710b05e2a3d216b2a8
 And kill the duplicate one in HsSyn.Convert
] 
[point to the wiki
Simon Marlow <marlowsd@gmail.com>**20090723132345
 Ignore-this: c11300bac62ce2f56d7fc271aa26dbcd
] 
[Remove note about avoiding use of #def in libraries
Simon Marlow <marlowsd@gmail.com>**20090723111026
 Ignore-this: 8a027ed37b2d10094f7a31548aee2535
 It should be safe to use now that we aren't relying on C prototypes
 for foreign functions in via-C code.
] 
[refactorings
Simon Marlow <marlowsd@gmail.com>**20090723091230
 Ignore-this: 836feb0e819127603dd56623af6e48dc
] 
[Fix Trac #3391: make generic to/from bindings only for newly-declared types
simonpj@microsoft.com**20090723155803
 Ignore-this: bb56c2ec054397d421dce13d5eb6c73f
 
 Before this patch we were bogusly making to/from bindings for all data types
 in the TcGblEnv.  But that is wrong when we have multiple "chunks" of 
 bindings in Template Haskell.  We should start from the declarations 
 themselves.  Easy.
 
] 
[Print explicit braces and semicolons in do-notation
simonpj@microsoft.com**20090723152411
 Ignore-this: a97ddf19774d27d15a01d63787708b20
 
 By printing explicit braces we make it more likely that pretty-printed
 code will be acceptable if fed back into GHC.
 
 See http://www.haskell.org/pipermail/glasgow-haskell-users/2009-July/017554.html
 
] 
[Documentation for stand-alone deriving (Trac #3012)
simonpj@microsoft.com**20090723132558
 Ignore-this: 54445c5984594eb7f82151b2ac118695
] 
[Windows only: set the encoding on stdin to utf8
Simon Marlow <marlowsd@gmail.com>**20090723121913
 Ignore-this: d65115d9711b5fb68e77786565ef6de
 Otherwise it defaults to latin1.
] 
[Fix Trac #3012: allow more free-wheeling in standalone deriving
simonpj@microsoft.com**20090723130145
 Ignore-this: 357580b9388ccbe1da3c1da3ba90e456
 
 In standalone deriving, we now do *not* check side conditions.
 We simply generate the code and typecheck it.  If there's a type
 error, it's the programmer's problem. 
 
 This means that you can do 'deriving instance Show (T a)', where
 T is a GADT, for example, provided of course that the boilerplate
 code does in fact typecheck.
 
 I put some work into getting a decent error message.  In particular
 if there's a type error in a method, GHC will show the entire code
 for that method (since, after all, the user did not write it).
 Most of the changes are to achieve that goal.
 
 Still to come: changes in the documentation.
 
] 
[Use the ErrMsg record type
simonpj@microsoft.com**20090723130108
 Ignore-this: 7fb6dd78d3185da0c33901b8aac8d108
] 
[Stop generating redundant parens in 'deriving' code
simonpj@microsoft.com**20090723125903
 Ignore-this: 6fc82df9648a82bcf7bf6fdfa9b4dad3
 
 This makes the code printed by -ddump-deriv look prettier
 
] 
[Wibble to printing tuple sections
simonpj@microsoft.com**20090723125756
 Ignore-this: af2a1b9784f6447fea0e11d454cf082f
] 
[Fix Trac #3193: improve line number reporting for equality constraints
simonpj@microsoft.com**20090723065504
 Ignore-this: b45a68071bcaca48cad7855dccb9c9eb
 
 When reporting an error from a failed equality constraint, we were
 setting the *context* but not the *line number* in TcTyFuns.eqInstMisMatch
 As a result, the line number didn't match the context at all.  It's
 trivial to fix.
 
 I'm 99% certain this fixes #3193, but it's too complicated to
 reproduce, so I have not actually tested it.
 
] 
[Add fmapM_maybe :: Monad m => (a -> m b) -> Maybe a -> m (Maybe b)
simonpj@microsoft.com**20090723064932
 Ignore-this: db5f6319b52a5e6b5f85d76985f2a7c9
 
 This function isn't used at the moment, but Max added it, and it
 looks useful.
 
] 
[Add tuple sections as a new feature
simonpj@microsoft.com**20090723063859
 Ignore-this: d42a26fc1efff112b852b5c1135c1746
 
 This patch adds tuple sections, so that
 
        (x,,z)  means   \y -> (x,y,z)
 
 Thanks for Max Bolinbroke for doing the hard work.
 
 In the end, instead of using two constructors in HsSyn, I used
 just one (still called ExplicitTuple) whose arguments can be
        Present (LHsExpr id)
 or     Missing PostTcType
 
 While I was at it, I did a bit of refactoring too.
 
] 
[NetBSD defines _REENTRANT in its header files, so compiling ghc gives
Simon Marlow <marlowsd@gmail.com>**20090723075030
 Ignore-this: 4722c4ff0541c6080de8f433e498684
 redefinition warnings for all files that are including includes/Rts.h.
 
 Contributed by: Krister Walfridsson <krister.walfridsson@gmail.com>
] 
[includes/TSO.h: kill trailing whitespace
Samuel Bronson <naesten@gmail.com>**20090722170354
 Ignore-this: 36d4afd1a21188d604ed6b432942dcdc
] 
[Say what StgTSOBlockInfo is for, where to read about it.
Samuel Bronson <naesten@gmail.com>**20090722163011
 Ignore-this: 6c09e11f23594251cdc2db1bc642edc9
] 
[Make the Integer library used directly configurable in GHC and base
Ian Lynagh <igloo@earth.li>**20090722151048
 Rather than indirecting through an integer package
] 
[Fix cleaning with the new integer changes
Ian Lynagh <igloo@earth.li>**20090722142545] 
[Add integer-simple as a build option
Ian Lynagh <igloo@earth.li>**20090722013137] 
[Tweak whitespace
Ian Lynagh <igloo@earth.li>**20090719221303] 
[thenIO, bindIO, returnIO moved to GHC.Base
Simon Marlow <marlowsd@gmail.com>**20090722102219
 Ignore-this: 5d6c5988e0abab2c5169540aa8ddedb9
] 
[remove unused $(HscIfaceFileVersion)
Simon Marlow <marlowsd@gmail.com>**20090720145053
 Ignore-this: d725cbbde3c68673e2342b370460d87f
] 
[Choose external names more predictably
Simon Marlow <marlowsd@gmail.com>**20090720144751
 Ignore-this: 17513bc93af646108f21bbed1c8f4a3a
 
 Now, for a compiler-generated binding "x", if "x" is referred to by
 the exported "f", then it will be named "f_x" rather than something
 like "x23".  This means that hopefully
 
   - compilation will more often product the same results given the
     same input (the choice of names is not dependent on the
     non-deterministic order of bindings within the compiler).
 
   - less recompilation will be necessary after making changes
 
   - navigating Core might be a bit easier.
 
 unfortunately, compilation with -O still does not consistently produce
 the same ABI.  The simplifier sometimes does different things,
 apparently.
 
 Names will be longer, but I can't see a way around that.
] 
[Use stable ordering in the dependencies
Simon Marlow <marlowsd@gmail.com>**20090717123449
 Ignore-this: e20bac233cf6f834e69c027ff60b5b50
 Fixes another cause of wobbly interface files and unnecessary recompilation.
] 
[fall back on libffi for 'foreign import "wrapper"' if necessary
Simon Marlow <marlowsd@gmail.com>**20090716134549
 Ignore-this: e1073e1ad77e720326865a6d3c4f3790
] 
[Take account of GADTs when reporting patterm-match overlap
simonpj@microsoft.com**20090722050933
 Ignore-this: 7dcbdcb91021e83e6e6208a2e68c50c9
 
 When matching against a GADT, some of the constructors may be impossible.
 For example
        data T a where
           T1 :: T Int
           T2 :: T Bool
           T3 :: T a
 
         f :: T Int -> Int
         f T1 = 3
         f T3 = 4
 
 Here, does not have any missing cases, despite omittting T2, because
 T2 :: T Bool.
 
 This patch teaches the overlap checker about GADTs, which happily
 turned out to be rather easy even though the overlap checker needs
 a serious rewrite.
 
] 
[Fix Trac #3382: desugaring of NPats
simonpj@microsoft.com**20090720061226
 Ignore-this: 4dccdaf2b7d6428141dcf174cb455a20
 
 Max spotted that the short-cut rules for desugaring NPats (where
 we compare against a literal) were wrong now that we have overloaded
 strings.
 
] 
[Add a -fwarn-dodgy-exports flag; fixes #1911
Ian Lynagh <igloo@earth.li>**20090719200124
 This is used to control warnings that were previously unconditional.
] 
[Build terminfo if we /aren't/ on Windows, not if we /are/
Ian Lynagh <igloo@earth.li>**20090719111709] 
[Change how PACKAGES is constructed, so that everything gets cleaned properly
Ian Lynagh <igloo@earth.li>**20090718210058
 If Windows wasn't defined properly then the Win32 package wasn't being
 cleaned, as it wasn't added to PACKAGES. Now we always add everything to
 PACKAGES when CLEANING=YES.
] 
[temporarily turn off unused import warnings for the time library
Ian Lynagh <igloo@earth.li>**20090718183445] 
[Follow the split directory rename in the GHC build system rules
Ian Lynagh <igloo@earth.li>**20090718155618] 
[Add osuf to the name we use for the split dir
Ian Lynagh <igloo@earth.li>**20090718145522
 This avoids a collision between the directories we use when compiling
 multiple ways, which in turn leads to a race condition in parallel
 builds.
] 
[Temporarily turn off unused-do-bind warnings for the time package
Ian Lynagh <igloo@earth.li>**20090718134536] 
[Make ghc-cabal handle "Custom" Setup.hs files that have a configure script
Ian Lynagh <igloo@earth.li>**20090718131555] 
[Add the time library, and support for libraries in tarballs
Ian Lynagh <igloo@earth.li>**20090718121649] 
[Always serialise Int as 64bit values; fixes trac #3041
Ian Lynagh <igloo@earth.li>**20090717224203
 This means that, provided the values are small enough, files
 serialized are portable between architectures. In particular,
 .haddock files are portable.
] 
[Remove some code that has always been commented out
Ian Lynagh <igloo@earth.li>**20090717224100] 
[Fix Trac #3346: tcSimplify for LHS of RULES with type equalities
simonpj@microsoft.com**20090717155722
 Ignore-this: dfdd0f9a62d78d63276a4d558831099c
] 
[Allow mixed case in the LINE pragma; patch from squadette; fixes #1817
Ian Lynagh <igloo@earth.li>**20090717133522] 
[Comment only
simonpj@microsoft.com**20090717120154
 Ignore-this: f96b11e602fe4b311c1e466af9aa1908
] 
[Add missing case for eq_note.
t-peterj@microsoft.com**20090624134407] 
[Rename parameters to make debugging code compile.
t-peterj@microsoft.com**20090626105440] 
[Comment fix: use the same variable names in the conclusion as in the premise.
t-peterj@microsoft.com**20090618092235] 
[Typo fixes, from Alexey Mahotkin
Ian Lynagh <igloo@earth.li>**20090717010817] 
[Use names like '$fOrdInt' for dfuns (and TF instances), rather than '$f21'
Simon Marlow <marlowsd@gmail.com>**20090716125643
 Ignore-this: d0b4632cf8ed9e05b67a19aa19ab3e19
 
 2 reasons for this:
   - compilation is more predictable.  Adding or removing an instance
     is less likely to force unnecessary recompilation due to
     renumbering other dfun names.
   - it makes it easier to read Core / C-- / asm
 
 The names aren't completely deterministic.  To do that, we'd have to
 include package and module names, which would make the symbol names
 long and reduce readability.  So the compromise is that if there's a
 clash, we disambiguate by adding an integer suffix.  This is fairly
 unlikely in practice unless you're using overlapping instances.
 
 Type family instances are handled in the same way, with the same
 disambiguation strategy.
] 
[Use a stable ordering for the export list in the interface
Simon Marlow <marlowsd@gmail.com>**20090716122601
 Ignore-this: 847dd7adc8b52e56f28d2478c78c925
 The export list was ordered according to the whim of FastStrings,
 which meant that interface fingerprints could change for no good
 reason, causing spurious recompilation.
] 
[Don't put all of $CFLAGS into $SRC_CC_OPTS
Ian Lynagh <igloo@earth.li>**20090716131309
 Instead, we just put the flags we need in there (e.g. -m64 on OS X 64).
 This fixes a problem found by Simon M, where we were compiling
 everything with -g, leading to a bloated RTS.
] 
[Move showOpt into DynFlags
Ian Lynagh <igloo@earth.li>**20090716005314] 
[Make the --info values printable with "ghc --print-foo"; trac #3122
Ian Lynagh <igloo@earth.li>**20090716001718
 Also, libdir is now part of the --info output, so this subsumes the old
 --print-libdir flag.
 The mode parsing was getting rather adhoc, so I've tidied it up a bit
 in the process.
] 
[whitespace only
Simon Marlow <marlowsd@gmail.com>**20090716104217
 Ignore-this: 38cff291d9ef15c30e3ed685ffc3c9f9
] 
[refactor: use packageConfigId in place of mkPackageId . package
Simon Marlow <marlowsd@gmail.com>**20090716104145
 Ignore-this: f3d73e7bd1b307a67d26585c49f3d89f
] 
[Fix a flag name in the docs
Ian Lynagh <igloo@earth.li>**20090714165943] 
[Add the -fno-shared-implib flag
Ian Lynagh <igloo@earth.li>**20090714165631
 Patch from
     Max Bolingbroke <batterseapower@hotmail.com>
 Rerecorded to avoid conflicts.
] 
[Derived Foldable instances should use Data.Foldable.foldr
m.niloc@gmail.com**20090711130647
 Ignore-this: e3eb841e9535a842a98bb1ae0532c6e8
] 
[remove Solaris-specific hacks, now unnecessary
Simon Marlow <marlowsd@gmail.com>**20090713083524
 Ignore-this: 500077008e463532e0677ee82f5284bb
] 
[Simplify timestamp restoration
Matthias Kilian <kili@outback.escape.de>**20090711100244
 Ignore-this: 7eaede224befa6b5368c91b92366211
] 
[FIX #3272
Manuel M T Chakravarty <chak@cse.unsw.edu.au>**20090714054559
 Ignore-this: 225fe4d82d4eed02e9b1377687661bac
] 
[Fix warnings
Roman Leshchinskiy <rl@cse.unsw.edu.au>**20090713092032
 Ignore-this: 3631b87164fc54d82e3a02875dc08f7d
] 
[Separate length from data in DPH arrays
Roman Leshchinskiy <rl@cse.unsw.edu.au>**20090713044212
 Ignore-this: aa2cc3b5ae43bd2c493ce4b330c883cd
] 
[Stop using -fno-warn-unused-do-bind when compiling the libraries
Ian Lynagh <igloo@earth.li>**20090709160422
 They're now fixed to not generate those warnings
] 
[Remove maybePrefixMatch, using stripPrefix instead
Ian Lynagh <igloo@earth.li>**20090709160412
 We already require GHC 6.8 to build, and that included stripPrefix
 in Data.List.
] 
[TFs: FIX #2203 (second half)
Manuel M T Chakravarty <chak@cse.unsw.edu.au>**20090710064834
 Ignore-this: 46a46feaa73f74feb08524b9e7547414
] 
[TFs: Fix should_compile/Simple8
Manuel M T Chakravarty <chak@cse.unsw.edu.au>**20090710042728
 Ignore-this: 471ab67e3df1c5245921be5286a45f93
] 
[workaround new Cygwin bash CRLF behaviour
Simon Marlow <marlowsd@gmail.com>**20090709132850
 Ignore-this: 5cfa2cc9d776ebe315c0f6ad7ab56d98
] 
[Use /usr/bin/test if it exists, and fix test syntax.
Simon Marlow <marlowsd@gmail.com>**20090709124616
 Ignore-this: 83a75ba7c3ce2a1d02bddb7bfe414bfe
 Should fix Solaris build failures
] 
[Allow mixed case pragmas; #1817. Patch from squadette
Ian Lynagh <igloo@earth.li>**20090709153737
 This patch allow you to use "Language CPP", or even "LaNgUaGe CPP",
 if you wish, as the manual claims you can.
] 
[don't create inplace/bin/ghc-<version>
Simon Marlow <marlowsd@gmail.com>**20090706092031
 Ignore-this: 2584d7bf56e77b27ca5b7b557c152c5e
] 
[Fix ignored-monadic-result warnings
Ian Lynagh <igloo@earth.li>**20090707181857] 
[Fix an unused import warning
Ian Lynagh <igloo@earth.li>**20090707144706] 
[Fix unused import warnings
Ian Lynagh <igloo@earth.li>**20090707143216] 
[Fix unused import warnings
Ian Lynagh <igloo@earth.li>**20090707133537] 
[When exporting F(..), all the children of F are also exported
Ian Lynagh <igloo@earth.li>**20090707133427
 This fixes the unused imports warning when
     Foo (F(x,y,z))
 is imported and
     Foo (F(..))
 is exported.
] 
[Remove unused imports
Ian Lynagh <igloo@earth.li>**20090707121548] 
[Major patch to fix reporting of unused imports
simonpj@microsoft.com**20090706112503
 Ignore-this: 3b5ecdd880474493d73bdbdc0fa0b782
 
 This patch, joint work between and Ian and Simon, fixes Trac #1074
 by reporting unused import declarations much more accuratly than 
 before.  The specification is described at 
 
 http://hackage.haskell.org/trac/ghc/wiki/Commentary/Compiler/UnusedImports
 
 The implementation is both easier to understand than before, and shorter
 too.  
 
 Also fixed are #1148, #2267
 
 Also fixed is -ddump-minimal imports, which now works properly, fixing 
 Trac #1792.
 
 
] 
[Trim unused imports detected by new unused-import code
simonpj@microsoft.com**20090706112201
 Ignore-this: c6ca46d3a750c1cd1d58ea2c0de9f14f
] 
[Avoid unnecessary recompilation after ./configure (helps #3228)
Simon Marlow <marlowsd@gmail.com>**20090707085040
 Ignore-this: f8b3e7a2a96bc23cd29505ab9c8dbd7d
 We cache the old versions of files generated by configure, so that if
 configure touches the file without changing it, we can detect that and
 restore the timestamp.
] 
[check for tabs in compiler/ghc.cabal.in (#3344)
Simon Marlow <marlowsd@gmail.com>**20090707081845
 Ignore-this: 6073db47eafd52e13e76c58ef738afcf
] 
[remove tabs
Simon Marlow <marlowsd@gmail.com>**20090707081823
 Ignore-this: 3d65831fc019f76cefac03291904842a
] 
[fix cleaning of libraries (now 'make clean' in libraries/* works again)
Simon Marlow <marlowsd@gmail.com>**20090703114638
 Ignore-this: b3af731d50ff5bfbd453f94aa40cb92c
] 
[FIX #2677
Manuel M T Chakravarty <chak@cse.unsw.edu.au>**20090707055442
 Ignore-this: e224dd09d0d1c9ec4f3b46c7accb8d57
] 
[Update driver/Makefile for the new build system
Ian Lynagh <igloo@earth.li>**20090705204041] 
[Fix generational GC bug (#3348)
Simon Marlow <marlowsd@gmail.com>**20090706112227
 Ignore-this: 5938338efa0ad1550968c664a5a76f31
] 
[Windows fixes to build system: use the 'find' and 'sort' found by configure
simonpj@microsoft.com**20090706103413
 Ignore-this: a96197917f388a637118bafefb427495
 
 The build system should use 'find' and 'sort' that are discovered by
 configure, not the ones in your path.  On Windows the ones in your path
 might well be the non-Unixy Windows versions.
 
 This patch fixes the ones I tripped over. There may be more.
 
] 
[Follow Cabal changes
Ian Lynagh <igloo@earth.li>**20090705180414] 
[Update TODO list
Ian Lynagh <igloo@earth.li>**20090705165009] 
[Make -fext-core a dynamic flag (it was a static flag)
Ian Lynagh <igloo@earth.li>**20090705132420] 
[Update a few points about shared libs in other sections
Duncan Coutts <duncan@well-typed.com>**20090704212212
 And add links to the new shared libs section.
] 
[Document -dynload flag. Also add it and -shared to the flags reference.
Duncan Coutts <duncan@well-typed.com>**20090704212119] 
[Add new section on using shared libs
Duncan Coutts <duncan@well-typed.com>**20090704212003] 
[Document foreign import prim in the user guide
Duncan Coutts <duncan@well-typed.com>**20090704180547
 Basically just stat that it exists and refer to the ghc dev wiki
 for the details, because we don't really want people using it.
] 
[For now, use -fno-warn-unused-do-bind when building the libraries
Ian Lynagh <igloo@earth.li>**20090704210654] 
[Make changes to -fwarn-unused-do-bind and -fwarn-wrong-do-bind suggested by SPJ
Max Bolingbroke <batterseapower@hotmail.com>**20090702150943
 Ignore-this: 595368298d2e11623c0bd280ff89d8de
] 
[Support for -fwarn-unused-do-bind and -fwarn-wrong-do-bind, as per #3263
Max Bolingbroke <batterseapower@hotmail.com>**20090701200344
 Ignore-this: 511117ffc10d4b656e530b751559b8b8
] 
[Improved infrastructure for fast-rebuilding of parts of the tree
Simon Marlow <marlowsd@gmail.com>**20090703074527
 Ignore-this: ab348d0988d8bbc28c2b4babbd6bbfb8
 
 e.g.
 
   cd compiler
   make FAST=YES stage1/build/HscTypes.o
 
 builds just the specified .o file, without rebuilding dependencies,
 and omitting some of the makefile phases.  FAST=YES works anywhere, to
 omit depenencies and phases.  'make fast' is shorthand for 'make
 all FAST=YES'.
] 
[Fix Trac #3342: missed zonking in TcHsSyn
simonpj@microsoft.com**20090702124331
 Ignore-this: 9b97b2142dfc665b503f59df7c55dd17
 
 The type in a ViewPat wasn't being zonked.  Easily fixed.
 
] 
[Type synonym families may be nullary
Manuel M T Chakravarty <chak@cse.unsw.edu.au>**20090702084826
 Ignore-this: bcfe6ed62c901206daf5a5088890bbea
] 
[New syntax for GADT-style record declarations, and associated refactoring
simonpj@microsoft.com**20090702094657
 Ignore-this: bd9817230d3773b3b01fae3d7f04c57d
 
 The main purpose of this patch is to fix Trac #3306, by fleshing out the
 syntax for GADT-style record declraations so that you have a context in 
 the type.  The new form is
    data T a where
      MkT :: forall a. Eq a => { x,y :: !a } -> T a
 See discussion on the Trac ticket.
 
 The old form is still allowed, but give a deprecation warning.
 
 When we remove the old form we'll also get rid of the one reduce/reduce
 error in the grammar. Hurrah!
 
 While I was at it, I failed as usual to resist the temptation to do lots of
 refactoring.  The parsing of data/type declarations is now much simpler and
 more uniform.  Less code, less chance of errors, and more functionality.
 Took longer than I planned, though.
 
 ConDecl has record syntax, but it was not being used consistently, so I
 pushed that through the compiler.
 
] 
[White space only
simonpj@microsoft.com**20090702094627
 Ignore-this: 19f654cbf371c8dcc6517fd4934855b4
] 
[Comments only
simonpj@microsoft.com**20090702094531
 Ignore-this: 384fc2729c7c50a1680775a1f9ff89e4
] 
[Look through Notes when matching
simonpj@microsoft.com**20090702094444
 Ignore-this: 7daea81e905ec6061d3e0fd588d7e61b
] 
[FIX #3197
Manuel M T Chakravarty <chak@cse.unsw.edu.au>**20090702070905
 Ignore-this: ebf829f0ae025e82bccdfa4345828ffe
] 
[Fix #2197 (properly this time)
Simon Marlow <marlowsd@gmail.com>**20090701122354
 Ignore-this: 39b6e4b0bcdd8c2f4660f976b7db768d
 
 $ ./inplace/bin/ghc-stage2 --interactive
 GHCi, version 6.11.20090701: http://www.haskell.org/ghc/  :? for help
 ghc-stage2: GHCi cannot be used when compiled with -prof
 [1]    32473 exit 1     ./inplace/bin/ghc-stage2 --interactive
] 
[make GhcProfiled work, and add a "prof" flavour to build.mk
Simon Marlow <marlowsd@gmail.com>**20090701114211
 Ignore-this: 386d347e4ad8b6c2bd40a2ba7da31ba6
 
 Building a profiled GHC is as simple as adding
 
 GhcLibWays += p
 GhcProfiled = YES
 
 to your build.mk and saying 'make'.  Then you have a profiled
 inplace/bin/ghc-stage2.
] 
[remove unnecessary $(RM)s
Simon Marlow <marlowsd@gmail.com>**20090701110609
 Ignore-this: f326ec8931d0d484a66b67ce1270cc6e
] 
['make html' in a library builds the Haddock docs
Simon Marlow <marlowsd@gmail.com>**20090630111137
 Ignore-this: 781bf10e2d4bca23b7f70c6f0465d120
] 
[fix GC bug introduced with the C finalizer support
Simon Marlow <marlowsd@gmail.com>**20090630080834
 Ignore-this: 3567e3adb5ae4a5dcbce81733487f348
] 
[Add a configure test for whether or not __mingw_vfprintf exists
Ian Lynagh <igloo@earth.li>**20090627150501] 
[Fix #3319, and do various tidyups at the same time
Simon Marlow <marlowsd@gmail.com>**20090626095421
 Ignore-this: ea54175f6bd49e101d7b33392764f643
  - converting a THSyn FFI declaration to HsDecl was broken; fixed
  - pretty-printing of FFI declarations was variously bogus; fixed
  - there was an unused "library" field in CImport; removed
] 
[rename cache variable to keep recent autoconfs happy
Ross Paterson <ross@soi.city.ac.uk>**20090626131410
 Ignore-this: 187091bbe78f2b14402162acfb98180f
] 
[TAG 2009-06-25
Ian Lynagh <igloo@earth.li>**20090625155528] 
Patch bundle hash:
ae45a9e251bfa29cf95a5bac1cf7cbee16b80b50