Ticket #3288: reactive.patch

Fri Jun  5 12:48:26 CEST 2009  svein.ove@aas.no
  * Crash-causing nonchange

New patches:

[Crash-causing nonchange
svein.ove@aas.no**20090605104826
 Ignore-this: 1303b156448862f623f3d80dadaa7dfb
] {
hunk ./src/FRP/Reactive/PrimReactive.hs 93
 import Control.Instances () -- Monoid (IO ())
 
 
-import Data.Unamb (unamb, assuming)
+import Data.Unamb (unamb, assuming, unambs)
 import Data.Unamb (race)  -- eliminate
 
 -- import Data.Max
hunk ./src/FRP/Reactive/PrimReactive.hs 186
 -- On the other hand, they patch a massive space leak in filterE.  Perhaps
 -- there's an unamb solution.
 
-u `merge` v =
-  assuming (isNeverF u) v `unamb`
-  assuming (isNeverF v) u `unamb`
-  (inFutR (`merge` v) <$> u) `mappend` (inFutR (u `merge`) <$> v)
+u `merge` v = unambs
+  [assuming (isNeverF u) v,
+   assuming (isNeverF v) u,
+   (inFutR (`merge` v) <$> u) `mappend` (inFutR (u `merge`) <$> v)]
 
 -- TODO: redefine via parIdentity from Data.Unamb
 
hunk ./src/FRP/Reactive/PrimReactive.hs 193
--- u `merge` v | isNever u = v
---             | isNever v = u
+-- u `merge` v | isNeverF u = v
+--             | isNeverF v = u
+--             | otherwise = (inFutR (`merge` v) <$> u) `mappend` (inFutR (u `merge`) <$> v)
 
 -- Future (Max MaxBound,_) `merge` v = v
 -- u `merge` Future (Max MaxBound,_) = u
}

Context:

[TAG 0.11
Conal Elliott <conal@conal.net>**20090529234922] 
[0.11
Conal Elliott <conal@conal.net>**20090529234842] 
[AGPLv3
Conal Elliott <conal@conal.net>**20090529234750] 
[updated for QuickCheck 2
Conal Elliott <conal@conal.net>**20090528181717] 
[TAG 0.10.7
Conal Elliott <conal@conal.net>**20090521234303] 
Patch bundle hash:
b1616b41e9b395a20a5e2197bdbee75bbcd26d7c