Ticket #1161 (closed task: fixed)

Opened 6 years ago

Last modified 12 months ago

Clean up the library testing story

Reported by: simonmar Owned by: pcapriotti
Priority: normal Milestone: 7.6.1
Component: Test Suite Version: 6.7
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Difficulty: Moderate (less than a day)
Test Case: Blocked By:
Blocking: Related Tickets:

Description

Our story for testing libraries is in disarray, and needs cleaning up. Tests for libraries can now be placed in the repositories with the libraries themselves, and these tests are picked up when you say make in testsuite/tests/ghc-regress.

The following tests need to be moved into their respective packages, and in some cases given appropriate .T scripts:

  • everything in testsuite/tests/libraries
  • everything in testsuite/tests/ghc-regress/lib

tests that are package-specific but are really GHC regression tests should stay in the testsuite, and use the reqlib option.

Change History

Changed 6 years ago by simonmar

  • milestone changed from 6.8 branch to Not GHC

Changed 5 years ago by simonmar

  • architecture changed from Unknown to Unknown/Multiple

Changed 5 years ago by simonmar

  • os changed from Unknown to Unknown/Multiple

Changed 4 years ago by simonmar

  • difficulty changed from Moderate (1 day) to Moderate (less than a day)

Changed 2 years ago by igloo

  • owner set to igloo
  • failure set to None/Unknown
  • milestone changed from Not GHC to 7.4.1

Changed 2 years ago by duncan

In my opinion, we should try to have libraries use the new cabal test interface (improving that if necessary) and the ghc testsuite can call that.

We want the cabal test interface anyway since it gives a standard interface for all packages and will let us share continuous testing infrastructure across all packages (e.g. the HP).

Changed 2 years ago by simonmar

How would cabal test interact with the GHC testsuite infrastructure? We have lots of parameters to pass in (compiler, flags, ways etc.), and information to get out again (the result of each test), and some infrastructure we might want to share (the test driver).

I'm wondering whether a better approach might be to have both an all.T as well as the cabal test infrastructure (whatever that might be) for each package.

Changed 18 months ago by igloo

lib/Data.ByteString tests sent to bytestring bug report addresses. I'll remove them from testsuite once we've stopped merging everything to 7.4.

Changed 18 months ago by igloo

  • milestone changed from 7.4.1 to 7.6.1

Can't finish this in 7.4, as we aren't pulling library patches from upstreams any more, so punting.

Changed 15 months ago by pcapriotti

  • owner changed from igloo to pcapriotti

Changed 12 months ago by pcapriotti

  • status changed from new to closed
  • resolution set to fixed

All tests have been moved to the appropriate repositories.

The only thing remaining in lib/ is integer, which should probably stay there, since it is not specific to the Integer implementation, so I'm closing this.

Note: See TracTickets for help on using tickets.