hppa port -- gmp handed misaligned memory

GMP compiled for hppa 2.0n uses 8 byte data by default. hppa *requires* that 8 byte data be aligned on an 8 byte boundary. However GHC only aligns allocated memory to a 4 byte boundary. This causes GHC to crash. Currently the workaround is to recompile GMP to use 32 bit data, but this is probably a performance hit.

Joe Buehler

Trac metadata

Trac field	Value
Version	6.6.1
Type	Bug
TypeOfFailure	OtherFailure
Priority	normal
Resolution	Unresolved
Component	Runtime System
Test case
Differential revisions
BlockedBy
Related
Blocking
CC
Operating system
Architecture

changed weight to 5

added RTS Tbug Trac import labels

changed milestone to %6.8.2

changed milestone to %6.8.3

I think that something like this might be the way to go:

diff -rN -u old-val/rts/PrimOps.cmm new-val/rts/PrimOps.cmm
--- old-val/rts/PrimOps.cmm     2008-05-24 02:20:52.000000000 +0100
+++ new-val/rts/PrimOps.cmm     2008-05-24 02:21:06.000000000 +0100
@@ -546,23 +546,33 @@
 
 /* ToDo: this is shockingly inefficient */
 
+#if defined(hpux_HOST_OS)
+#define MP_ALIGN align 8;
+#else
+#define MP_ALIGN
+#endif
+
 #ifndef THREADED_RTS
 section "bss" {
+  MP_ALIGN
   mp_tmp1:
     bits8 [SIZEOF_MP_INT];
 }
 
 section "bss" {
+  MP_ALIGN
   mp_tmp2:
     bits8 [SIZEOF_MP_INT];
 }
 
 section "bss" {
+  MP_ALIGN
   mp_result1:
     bits8 [SIZEOF_MP_INT];
 }
 
 section "bss" {
+  MP_ALIGN
   mp_result2:
     bits8 [SIZEOF_MP_INT];
 }
@@ -691,6 +701,7 @@
 
 #ifndef THREADED_RTS
 section "bss" {
+  MP_ALIGN
   mp_tmp_w:  W_; // NB. mp_tmp_w is really an here mp_limb_t
 }
 #endif

but (in the HEAD) having the align on amd64/Linux gives me:

../compiler/ghc-inplace -Werror -H64m -Onot -fasm -optc-O2 -I../includes -I. -Iparallel -Ism -DCOMPILING_RTS -package-name rts -fvia-C -static  -I../gmp/gmpbuild -I../libffi/build/include -I. -dcmm-lint     -c PrimOps.cmm -o PrimOps.o
ghc-6.9.20080523: panic! (the 'impossible' happened)
  (GHC version 6.9.20080523 for x86_64-unknown-linux):
        PprC.pprTop: can't handle this data

Please report this as a GHC bug:  http://www.haskell.org/ghc/reportabug

make[1]: *** [PrimOps.o] Error 1

changed milestone to %6.10.1

changed milestone to %6.10 branch

mentioned in issue #2917 (closed)

changed milestone to %6.12 branch

See also #2917 (closed).

Trac metadata

Trac field	Value
TypeOfFailure	- → RuntimeCrash

changed milestone to %6.12.3

removed milestone

changed weight to 3

Trac metadata

Trac field	Value
Priority	normal → low

changed milestone to %7.0.2

changed milestone to %7.2.1

changed milestone to %7.4.1

changed milestone to %7.6.1

changed weight to 0