Ticket #1848 (closed bug: fixed)

Opened 6 years ago

Last modified 4 years ago

Binary distributions don't install gmp

Reported by: simonmar Owned by: igloo
Priority: high Milestone: 6.8.2
Component: Build System Version: 6.8.1
Keywords: gmp Cc: chak@…
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: Difficulty: Easy (less than 1 hour)
Test Case: Blocked By:
Blocking: Related Tickets:

Description

Manuel Chakravarty writes:

Unfortunately, make binary-dist is broken in the HEAD and the 6.8 branch for systems without a pre-installed gmp library. The reason is that distrib/Makefile lacks code that installs the embedded gmp. For the Mac OS X 10.5 binary distribution that I just announced on the GHC users list, I patched the Makefile with the attached patch. However, I am not sure whether that's the best/intended way of doing this. (Just invoking gmp/Makefile doesn't work, but it might be nice to fix that instead of inlining the GMP install in the toplevel Makefile.)

What's the Right Thing to do here?

Manuel

Attachments

Makefile.patch Download (0.5 KB) - added by chak 6 years ago.

Change History

Changed 6 years ago by chak

Changed 6 years ago by igloo

  • cc chak@… added

Adding

$(MAKE) -C gmp       install      DOING_BIN_DIST=YES

somewhere in the install target of distrib/Makefile sounds like the right thing to do, but I assume that's what you mean by "Just invoking gmp/Makefile doesn't work". What goes wrong when you try that?

Changed 6 years ago by simonmar

  • priority changed from normal to high

Changed 5 years ago by igloo

  • owner set to igloo

Changed 5 years ago by igloo

I've applied the fix I suggested above, but haven't yet tested it with a bindist that needs to install gmp.

Changed 5 years ago by igloo

  • status changed from new to closed
  • resolution set to fixed

I've tweaked the fix slightly, and it now works (HEAD and 6.8 branch).

Changed 5 years ago by simonmar

  • architecture changed from Unknown to Unknown/Multiple

Changed 5 years ago by simonmar

  • os changed from Unknown to Unknown/Multiple

Changed 4 years ago by simonmar

  • difficulty changed from Easy (1 hr) to Easy (less than 1 hour)
Note: See TracTickets for help on using tickets.