Ticket #2227 (closed proposal: fixed)

Opened 5 years ago

Last modified 5 years ago

(fgl) reimplement Data.Graph.Inductive.Query.Dominators

Reported by: int-e Owned by:
Priority: normal Milestone:
Component: libraries (other) Version: 6.9
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: Difficulty:
Test Case: Blocked By:
Blocking: Related Tickets:

Description

As pointed out at  http://www.haskell.org/pipermail/haskell-cafe/2008-April/041739.html ff., Data.Graph.Inductive.Query.Dominators.dom is buggy. Furthermore, it's slow, so instead of submitting the quick fix from that thread, I've rewritten the module from scratch using a more efficient algorithm.

The algorithm works by calculating the immediate dominators of the graph nodes first, so the patch also adds a function that returns those. It should be handy for flow graph analysis.

Attachments

dominators.patch Download (7.4 KB) - added by int-e 5 years ago.
proposed patch

Change History

Changed 5 years ago by int-e

proposed patch

Changed 5 years ago by int-e

FGL is not a core package (but an extra package shipped with ghc), so the library submission guidelines don't apply.

As per Don Stewart's suggestion on libraries@… I've contacted Martin Erwig about this.

Changed 5 years ago by int-e

  • status changed from new to closed
  • resolution set to fixed

Martin Erwig kindly applied the patch.

Changed 5 years ago by simonmar

  • architecture changed from Multiple to Unknown/Multiple

Changed 5 years ago by simonmar

  • os changed from Multiple to Unknown/Multiple
Note: See TracTickets for help on using tickets.