Generic functions that take integral arguments should work the same way as their prelude counterparts

[japple]

The Prelude functions drop, take, and splitAt are unfailing (never call error). This patch changes the Data.List generic versions to behave the same way. At present, they call error on negative arguments.

quickCheck (\x n -> take n x == genericTake n x) quickCheck (\x n -> drop n x == genericDrop n x) quickCheck (\x n -> splitAt n x == genericSplitAt n x)

The library submission procedures say

If the changes update Haddoc [sic] documentation, also attach the resulting Haddock-generated pages.

Haddock fails on the file because of existing CPP commands.

[japple]

Deadline: Sept 7

[malcolm.wallace@…]

I agree that the generic versions should match the behaviour of the Int-specific versions. As I recall, the Int-specific Prelude functions originally called error, but this was changed around the time of Haskell 1.4/H'98. The failure to change the generic versions at the same time was just an oversight.

[japple]

Malcolm, can you push these changes?

[malcolm.wallace@…]

Igloo, I have applied the final patch to the haskell-report repository, but am guessing that you might prefer to validate the changes to base and testsuite before pushing them.

[igloo]

I've applied the patches, thanks!