-fasm codeGen doesn't truncate CMMInt's at the right place

[TristanAllwood]

With this sample program:

{-# LANGUAGE MagicHash, UnboxedTuples #-}
module Simpl(complement) where

import GHC.Base
import GHC.Num

complement (I# x#) = I# (word2Int# (int2Word# (4294967295#) `xor#` int2Word# (-1#)))

And compiling with

-O0 -fasm

on 6.10 or a recent head blows up in the assembler due to the constant.

Assembler messages:
Error: missing or invalid immediate expression `-4294967296' taken as 0
Error: suffix or operands invalid for `mov'

After some debugging with SPJ, we believe that what is happening is:

CMMIntis storing 4294967295 as an Integer. This magic number is (2^32) - 1.

4294967295 ^ -1 is 00..011..1 ^ 11..111..1 = 11..100..0 which is (-4294967296)

We think internally using Integer arithmatic is fine (in e.g. CmmOpt?), however truncation isn't happening correctly when turning the Integer into a real Int; makeImmediate in nativeGen\machineRegs looks like a possible culprit.

[TristanAllwood]

For reference, the test case does seem to be handled fine with -fnew-codegen in Today's Head.

[TristanAllwood]

given it's wrapped in #ifdef powepc, makeImmediate was probably a red herring.

[simonmar]

Replying to TristanAllwood:

For reference, the test case does seem to be handled fine with -fnew-codegen in Today's Head.

I suspect this is by accident, as the new codegen is not running CmmOpt.

[igloo]

What platform do you see this on?

[TristanAllwood]

I can reproduce under both Windows (vista) and linux i686

[simonmar]

Fixed, thanks:

Tue Dec  9 02:55:15 PST 2008  Simon Marlow <marlowsd@gmail.com>
  * Fix #2838: we should narrow a CmmInt before converting to ImmInteger

[igloo]

Merged.