Ticket #3270 (closed proposal: fixed)

Opened 4 years ago

Last modified 4 years ago

Stop using PackedString in template-haskell; drop packedstring as a bootlib

Reported by: simonmar Owned by:
Priority: normal Milestone: Not GHC
Component: None Version: 6.10.2
Keywords: Cc: gwern0@…
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: Difficulty: Unknown
Test Case: Blocked By:
Blocking: Related Tickets:

Description

The packedstring library has been superseded by the bytestring and text libraries, yet we are still shipping it with GHC for only one reason: it is used in the representations of three types in template-haskell.

The proposal is that we

  • make the types ModName, PkgName, and OccName from Language.Haskell.TH.Syntax into abstract newtypes (an API change)
  • change their representation from PackedString to String
  • drop the packedstring library from the bootlibs that GHC ships with

Relevant discussions:

Attachments

template-haskell.patch Download (6.8 KB) - added by simonmar 4 years ago.
ghc.patch.gz Download (187.2 KB) - added by simonmar 4 years ago.

Change History

Changed 4 years ago by simonmar

Changed 4 years ago by simonmar

Changed 4 years ago by guest

  • cc gwern0@… added

This change has my support.

Changed 4 years ago by simonmar

  • status changed from new to closed
  • resolution set to fixed

Done. In template-haskell: 

Fri Jun 12 11:17:36 BST 2009  Simon Marlow <marlowsd@gmail.com>
  * abstractify ModName, PkgName and OccName; drop dependency on packedstring

And ghc: 

Mon May 18 05:09:57 PDT 2009  Simon Marlow <marlowsd@gmail.com>
  * drop packedstring; it is no longer required by template-haskell
Note: See TracTickets for help on using tickets.