Ticket #3793 (closed merge: fixed)

Opened 3 years ago

Last modified 3 years ago

System.Time.toClockTime does not support all valid timezone offsets.

Reported by: daniel Owned by: igloo
Priority: high Milestone: 6.12.2
Component: libraries/old-time Version:
Keywords: tz timezone toClockTime Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: Incorrect result at runtime Difficulty: Easy (less than 1 hour)
Test Case: Blocked By:
Blocking: Related Tickets:

Description

toClockTime errors when the timezone offset is outside the range of -1200 to +1200. There are valid timezone offsets greater than +1200. Parts of Kiribati are, I believe, +1400.

Attached is a patch against the current head.

Attachments

timezone_offset.patch Download (1.7 KB) - added by daniel 3 years ago.

Change History

Changed 3 years ago by daniel

Changed 3 years ago by daniel

  • failure changed from Runtime crash to Incorrect result at runtime

Changed 3 years ago by simonmar

  • difficulty set to Easy (less than 1 hour)
  • milestone set to 6.12.2

Changed 3 years ago by simonmar

  • priority changed from normal to high

we have a patch; make it high prio

Changed 3 years ago by simonmar

  • owner set to igloo
  • type changed from bug to merge

Applied (packages/old-time): 

Mon Dec 28 22:07:03 GMT 2009  Daniel McAllansmith <dm.maillists@gmail.com>
  * Support timezone offsets up to +1400.
  Many places have timezone offsets greater than the previously allowed maximum
  of +1200, especially when in DST.
  Parts of Kiribati are +1400.

Changed 3 years ago by igloo

  • status changed from new to closed
  • resolution set to fixed

Merged as part of: 

Wed Jan 27 08:03:07 PST 2010  Ian Lynagh <igloo@earth.li>
  * Update to new versions of hpc and old-time
Note: See TracTickets for help on using tickets.