`gmake clean' or `gmake distclean' does not clean up testsuite directory

[kgardas]

Hello, as summary suggest, at least on Solaris `gmake clean' ends with following:

"rm" -rf libraries/integer-gmp/gmp/objs
"rm" -rf libraries/integer-gmp/gmp/gmpbuild
"rm" -rf bindistprep/
test ! -d testsuite || gmake -C testsuite clean
gmake[1]: Entering directory `/export/home/karel/vcs/ghc-new/testsuite'
gmake -C ./timeout clean
gmake[2]: Entering directory `/export/home/karel/vcs/ghc-new/testsuite/timeout'
./Setup clean
gmake[2]: ./Setup: Command not found
gmake[2]: [clean] Error 127 (ignored)
rm -f -rf install-inplace
rm -f -f calibrate.out
rm -f -f Setup Setup.exe Setup.hi Setup.o
gmake[2]: Leaving directory `/export/home/karel/vcs/ghc-new/testsuite/timeout'
gmake[1]: Leaving directory `/export/home/karel/vcs/ghc-new/testsuite'

which looks like it even does not attempt to enter testsuite/tests/ghc-regress subdirectory where a lot of tests is compiled (and consume space) for GHC testing

[igloo]

When running the full testsuite we'd normally run with CLEANUP=1, which cleans tests as it goes along, so normally there is nothing to clean (or perhaps 1 or 2 tests that have been run individually).

So we could run "make TEST=noSuchTest CLEANUP=1" when cleaning, but normally it'll just take some time and do nothing.

I wonder if we should default to CLEANUP=1 if TEST is not set?

[kgardas]

Ah, now I see CLEANUP=1 is well documented on wiki. Well so this was more my error expecting cleanup to be done by gmake clean/distclean'. Perhaps your idea of running CLEANUP=1 by default is the most simple fix for such casual tester who just check if gmake check; gmake test' or kind of that in root is working or not... So I'm all for it. Thanks!

[igloo]

Running make test in the root of the build tree now does the right thing.