Ticket #4380 (closed bug: fixed)

Opened 3 years ago

Last modified 2 years ago

Use throwIO instead of throw in an IO context

Reported by: basvandijk Owned by: simonmar
Priority: normal Milestone: 7.0.2
Component: libraries/base Version: 6.12.3
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Difficulty:
Test Case: Blocked By:
Blocking: Related Tickets:

Description

Some functions in base use throw where the type of the expression is IO. I think they should be using throwIO since it guarantees ordering with respect to other IO actions.

See the  thread on the libraries list.

Some simple benchmarks in the thread also showed that throwIO is faster than throw.

Attachments

throws-to-throwIOs.dpatch Download (50.0 KB) - added by basvandijk 3 years ago.

Change History

Changed 3 years ago by basvandijk

Changed 3 years ago by simonmar

  • owner set to simonmar

Changed 3 years ago by igloo

  • status changed from new to patch
  • milestone set to 7.0.2

Changed 2 years ago by simonmar

  • status changed from patch to closed
  • resolution set to fixed

This patch was applied.

Note: See TracTickets for help on using tickets.