Ticket #4961 (closed task: fixed)

Opened 2 years ago

Last modified 2 years ago

Make the Timeout exception a newtype instead of a datatype

Reported by: basvandijk Owned by:
Priority: normal Milestone: 7.4.1
Component: libraries/base Version: 7.0.1
Keywords: Cc:
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Difficulty:
Test Case: Blocked By:
Blocking: Related Tickets:

Description

The attached patch simply replaces the data with a newtype for the Timeout exception in  System.Timeout: 

-data    Timeout = Timeout Unique deriving Eq
+newtype Timeout = Timeout Unique deriving Eq

Attachments

make_Timeout_a_newtype.dpatch Download (64.9 KB) - added by basvandijk 2 years ago.

Change History

Changed 2 years ago by basvandijk

Changed 2 years ago by simonmar

  • owner set to simonmar
  • milestone set to 7.2.1

Obviously good, thanks. I'll push.

Changed 2 years ago by basvandijk

  • status changed from new to closed
  • resolution set to invalid

Simon, I noticed you didn't push yet. That's good because, as you know, I'm working on a faster timeout which doesn't really need this patch. So please don't push so I can obliterate the patch in my repository and keep the darcs log clean.

Thanks!

Changed 2 years ago by basvandijk

  • owner simonmar deleted
  • status changed from closed to new
  • resolution invalid deleted

Since I wasn't able to speedup the existing timeout, I'm reopening this ticket.

Sorry for the noise.

Changed 2 years ago by simonmar

  • status changed from new to closed
  • resolution set to fixed

Pushed today: 

Tue Feb 15 13:24:57 PST 2011  Bas van Dijk <v.dijk.bas@gmail.com>
  * Make the Timeout exception a newtype instead of a datatype
Note: See TracTickets for help on using tickets.