Ticket #5194 (closed bug: fixed)

Opened 2 years ago

Last modified 2 years ago

"Fix build" broke build?

Reported by: daniel.is.fischer Owned by: benl
Priority: normal Milestone:
Component: Compiler Version: 7.1
Keywords: Cc: mikhail.vorozhtsov@…
Operating System: Linux Architecture: x86
Type of failure: Building GHC failed Difficulty:
Test Case: Blocked By:
Blocking: Related Tickets:

Description

changeset 5bfa6a6382a4e4b949d333b1996065e9bcfacb18 removed import Config from compiler/nativeGen/AsmCodeGen.lhs, building failed with

compiler/nativeGen/AsmCodeGen.lhs:457:55:
    Not in scope: `cProjectVersion'

Reinserting the import made AsmCodeGen.lhs compile again, I'd be surprised if it breaks the build later on (build currently underway).

Change History

Changed 2 years ago by daniel.is.fischer

Built successfully, now running the testsuite.

Changed 2 years ago by mikhail.vorozhtsov

  • cc mikhail.vorozhtsov@… added

Changed 2 years ago by benl

  • owner set to benl

Sorry. I took out that import to fix a validate warning on OSX, but it broke other platforms. The occurrence of cProjectVersion is in an #ifdef, which is why it worked on OSX but not others. One more reason not to use #ifdef in Haskell code.

Changed 2 years ago by daniel.is.fischer

  • status changed from new to closed
  • resolution set to fixed

Fixed by changeset:a36cd6377ee2a65537fc02b78015937b50a69286

Note: See TracTickets for help on using tickets.