Ticket #5739 (closed bug: fixed)

Opened 17 months ago

Last modified 17 months ago

Please make LLVM binary names configurable

Reported by: nomeata Owned by: dterei
Priority: normal Milestone:
Component: Compiler (LLVM) Version: 7.3
Keywords: Cc: karel.gardas@…
Operating System: Unknown/Multiple Architecture: Unknown/Multiple
Type of failure: None/Unknown Difficulty: Unknown
Test Case: Blocked By:
Blocking: Related Tickets:

Description

While the name of the GCC binary, for example, is configurable in settings, this is not true for the LLVM binaries (llc and opt); these are hard-coded in source:/compiler/main/SysTools.lhs

This is required, e.g., for Debian where "opt" might be any llvm version and only "opt-3.0" would work. Ideally, we can set the name with ./configure and it would apply both for the build of ghc and the final ghc binary.

Attachments

llvm-cmds.diff Download (3.8 KB) - added by kgardas 17 months ago.

Change History

in reply to: ↑ description   Changed 17 months ago by igloo

  • difficulty set to Unknown

Replying to nomeata:

Ideally, we can set the name with ./configure and it would apply both for the build of ghc and the final ghc binary.

To clarify: We shouldn't use it when using the bootstrapping compiler: That version of GHC may require a different LLVM to be used, and the build system assumes that it already works without needing any special flags.

Changed 17 months ago by kgardas

  Changed 17 months ago by kgardas

I'm testing attached patch, which I hope satisfies igloo's requirement above and which once properly tested I'd like to commit and submit for inclusion usual git way.

  Changed 17 months ago by kgardas

  • cc karel.gardas@… added

  Changed 17 months ago by dterei

Any update Karel, is the patch attached good to apply?

  Changed 17 months ago by kgardas

Hi David, the patch is indeed good. I've been able to build on ARM/Linux with LLVM version not in PATH. Thanks for committing it.

  Changed 17 months ago by dterei

  • status changed from new to closed
  • resolution set to fixed

Committed: e6bfc5962e7d889a9cafcf1829c5177206ccabfd

Note: See TracTickets for help on using tickets.