Ticket #165 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

The ./configure configure hook should complain if ./configure does not exist

Reported by: guest Owned by:
Priority: normal Milestone:
Component: Cabal library Version: 1.2.0
Severity: normal Keywords:
Cc: Difficulty: very easy (<1 hour)
GHC Version: 6.4.2 Platform: Linux

Description

We often have problems with people not running auto(re)conf before Setup configure, and things breaking later on. The hook that runs ./configure should fail if ./configure doesn't exist; it probably shouldn't give any suggestion on how to create it, as people will blindly follow the suggestion and one size probably won't fit all.

This essentially depends on the proposals to split up hooks into smaller, composable parts.

Ian Lynagh

Change History

Changed 2 years ago by duncan

Certainly build-type: Configure should complain if ./configure cannot be found/run.

Similarly, defaultMainWithHooks autoconfHooks should fail if ./configure is not found, however defaultMainWithHooks defaultHooks is a mess because it's not actually the default but some packages use that thinking it is the default. Or if they extend defaultHooks but do not especially want to run ./configure. So it works for them at the moment but would fail if we made that a hard error.

Changed 2 years ago by duncan

I think we should deprecate defaultHooks and suggest people use simpleHooks or autoconfHooks.

Changed 2 years ago by duncan

  • status changed from new to closed
  • difficulty changed from normal to very easy (<1 hour)
  • resolution set to fixed

Done.

  • exported autoconfUserHooks
  • deprecated defaultUserHooks telling people to use either simpleUserHooks or autoconfUserHooks
  • changed autoconfUserHooks so that it fails if configure cannot be found.
  • kept defaultUserHooks behavior the same, ie run configure if it exists and don't fail if it does not.
Note: See TracTickets for help on using tickets.