Ticket #250 (closed defect: fixed)

Opened 9 months ago

Last modified 6 months ago

'haddock --executables" should dump the haddock interface too

Reported by: guest Assigned to:
Priority: normal Milestone:
Component: Cabal library Version: 1.2.3.0
Severity: normal Keywords:
Cc: Difficulty: normal
GHC Version: 6.8.2 Platform: Linux

Description

otherwise 'install' or 'copy --destdir=destdir' will fail with:

Setup.lhs: dist/doc/html/pkgid/pkgid.haddock: copyFile: does not exist (No such file or directory)

I tried to send a patch to the cabal-devel ML, but I'm not a subscriber, so I'm attaching the patch here.

Cheers

Attachments

dump_interface_for_Execs_too.dpatch (59.0 kB) - added by guest on 02/27/08 03:48:14.
fix_250.dpatch (59.5 kB) - added by guest on 02/28/08 08:29:59.

Change History

02/27/08 03:48:14 changed by guest

  • attachment dump_interface_for_Execs_too.dpatch added.

02/28/08 04:45:51 changed by duncan

Is it really useful to have the haddock interface for executables? Perhaps we should just not try to copy it when installing?

02/28/08 05:14:25 changed by guest

No it is not. You are right, but I saw a simple solution in front of me and I adopted it...;)

I'm reading Simple.Install right now and, if I understand it correctly, I think we should change something here to check if the '-executables' flag is used:

copyFileVerbose verbosity

(haddockPref pkg_descr </> haddockName pkg_descr) (interfacePref </> haddockName pkg_descr)

if you want I can send an amended patch when I find a second to study a bit the code. But maybe you already have the fix in mind.

Let me know.

Andrea Rossato

02/28/08 08:29:59 changed by guest

  • attachment fix_250.dpatch added.

02/28/08 08:31:38 changed by guest

this could probably be the cleanest solution: when an interface file exists it will get installed in the correct place.

Hope this helps.

ar

06/09/08 12:58:07 changed by duncan

  • status changed from new to closed.
  • resolution set to fixed.

Applied. Well, actually I had to change it a bit because of more recent changes.