Ticket #250 (closed defect: fixed)

Opened 5 years ago

Last modified 17 months ago

'haddock --executables" should dump the haddock interface too

Reported by: guest Owned by:
Priority: normal Milestone:
Component: Cabal library Version: 1.2.3.0
Severity: normal Keywords:
Cc: Difficulty: normal
GHC Version: 6.8.2 Platform: Linux

Description

otherwise 'install' or 'copy --destdir=destdir' will fail with:

Setup.lhs: dist/doc/html/pkgid/pkgid.haddock: copyFile: does not exist (No such file or directory)

I tried to send a patch to the cabal-devel ML, but I'm not a subscriber, so I'm attaching the patch here.

Cheers

Attachments

dump_interface_for_Execs_too.dpatch Download (59.0 KB) - added by guest 5 years ago.
fix_250.dpatch Download (59.5 KB) - added by guest 5 years ago.

Change History

Changed 5 years ago by guest

Changed 5 years ago by duncan

Is it really useful to have the haddock interface for executables? Perhaps we should just not try to copy it when installing?

Changed 5 years ago by guest

No it is not. You are right, but I saw a simple solution in front of me and I adopted it...;)

I'm reading Simple.Install right now and, if I understand it correctly, I think we should change something here to check if the '-executables' flag is used:

copyFileVerbose verbosity

(haddockPref pkg_descr </> haddockName pkg_descr) (interfacePref </> haddockName pkg_descr)

if you want I can send an amended patch when I find a second to study a bit the code. But maybe you already have the fix in mind.

Let me know.

Andrea Rossato

Changed 5 years ago by guest

Changed 5 years ago by guest

this could probably be the cleanest solution: when an interface file exists it will get installed in the correct place.

Hope this helps.

ar

Changed 5 years ago by duncan

  • status changed from new to closed
  • resolution set to fixed

Applied. Well, actually I had to change it a bit because of more recent changes.

Changed 17 months ago by elga

Note: See TracTickets for help on using tickets.