Ticket #253 (closed enhancement: fixed)

Opened 9 months ago

Last modified 7 months ago

Check for invalid operating system names

Reported by: duncan Assigned to:
Priority: normal Milestone: Cabal-1.4
Component: Cabal library Version: 1.2.3.0
Severity: normal Keywords:
Cc: Difficulty: easy (<4 hours)
GHC Version: 6.8.2 Platform:

Description

Some packages (eg hslogger-1.0.4) have incorrect operation system names tests: 

    if !os(win32)
        Build-Depends: unix

It's incorrect because there is no such operating system "win32", there is "windows" which is an alias for "mingw32".

So we should check for these problems. At the moment the OS is just a String . We should decide if we want to use an enumeration or leave it more flexible and just warn about unknown ones.

Checks are easy to add, see Distribution/PackageDescription/Check.hs

Change History

04/18/08 04:05:03 changed by duncan

  • difficulty changed from very easy (<1 hour) to easy (<4 hours).
  • milestone set to Cabal-1.4.

Requires an API change in Distribution.PackageDescription?.Check to take the GenericPackageDescription. Because it's a (minor) api change we should get it into Cabal-1.4.

04/23/08 08:35:17 changed by duncan

Fixed 

Wed Apr 23 16:14:10 BST 2008  Duncan Coutts <duncan@haskell.org>
  * Add checks for unknown OS Arch and Compiler names
  They're ok locally but for distribution they need to be known.

04/23/08 08:35:53 changed by duncan

  • status changed from new to closed.
  • resolution set to fixed.