Ticket #317 (closed enhancement: fixed)

Opened 5 years ago

Last modified 4 years ago

filter -threaded when profiling is on

Reported by: gbacon Owned by:
Priority: normal Milestone:
Component: Cabal library Version: HEAD
Severity: minor Keywords:
Cc: Difficulty: very easy (<1 hour)
GHC Version: 6.8.2 Platform:

Description

As a service to the community, please filter -threaded when profiling is on.

Attachments

ticket317.patch Download (13.6 KB) - added by alexeevg 4 years ago.
patch that fixes #317

Change History

Changed 5 years ago by duncan

  • priority changed from normal to low
  • difficulty changed from normal to very easy (<1 hour)
  • severity changed from normal to minor

For context, GHC rejects the combination of threaded and profiling. Some projects specify ghc-options: -threaded which means when some other developer comes along to profile this executable they bump into the error.

So perhaps Cabal should just filter out the option when building profiling executables and warn that it's doing so, since changing to the single threaded rts may have other behavioural effects.

Changed 4 years ago by mornfall

  • priority changed from low to normal

This breaks --enable-*-profiling for darcs as well. Since the autoconf-based build knows about this and we are trying to move to purely cabal-based solution, I use this as a justification for the priority bump. Thanks Duncan!

Changed 4 years ago by duncan

 http://hackage.haskell.org/trac/ghc/ticket/886 It seems that this got fixed in 6.10 so we should only filter it for ghc < 6.10.

Changed 4 years ago by alexeevg

patch that fixes #317

Changed 4 years ago by alexeevg

darcs send doesn't work on my system, so I thought I'd attach my patch here

Changed 4 years ago by duncan

  • status changed from new to closed
  • resolution set to fixed
Thu Jan 22 01:44:25 GMT 2009  Duncan Coutts <duncan@haskell.org>
  * filter -threaded when profiling is on
  Fixes #317. Based on a patch by gleb.alexeev@gmail.com
Note: See TracTickets for help on using tickets.