sdist doesn't not include source files from test-suite stanzas

[tibbe]

cabal sdist doesn't include the source files from test-suite stanzas when generating the tarball. This leads to Hackage's QA checks rejecting the package.

Steps to reproduce:

1. Create a Cabal package with a test-suite stanza (and set hs-source-dirs to e.g. tests).
2. Run cabal sdist
3. Unpack the tarball and look at the content.

Thomas, could you please take a look?

[duncan]

<dcoutts_> tibbe: is it the same with runghc Setup.hs sdist?
<dcoutts_> and what if you runghc Setup.hs configure --enable-tests first ?
* dcoutts_ suspects the latter might make it work
<tibbe> dcoutts_: same thing

[tibbe]

Just to clarify the above IRC discussion, the problem exists even if the package is configured using --enable-tests:

runghc Setup.hs configure --enable-tests --user
runghc Setup.hs sdist
tar -ztf dist/mypackage-1.0.tar.gz

[tibbe]

Workaround: List all the test-suites' source files under the global extra-source-files field.

[ttuegel]

Patch fixing sdist for test suites.

[ttuegel]

The patch I just attached fixes this problem when you do runghc Setup.hs sdist. My preliminary investigation shows that another patch for cabal-install will be necessary, but I haven't poked at the source yet.

[ttuegel]

Replying to ttuegel:

The patch I just attached fixes this problem when you do runghc Setup.hs sdist. My preliminary investigation shows that another patch for cabal-install will be necessary, but I haven't poked at the source yet.

I was wrong, this fixes cabal-install, too.

[duncan]

Applied.

Wed Jan 19 15:34:04 GMT 2011  Thomas Tuegel <ttuegel@gmail.com>
  * Including test suites in product of 'setup sdist'.
  See ticket #792.

[basvandijk]

I just received a  bugreport of one of my libraries about this.

Is the fix already in any released version?

[elga]

*  simyo