Ticket #830 (closed defect: fixed)

Opened 2 years ago

Last modified 17 months ago

Use wide Windows APIs in Cabal

Reported by: batterseapower Owned by:
Priority: normal Milestone:
Component: Cabal library Version: HEAD
Severity: normal Keywords:
Cc: Difficulty: unknown
GHC Version: Platform:

Description

As part of my work on GHC's Unicode support ( http://hackage.haskell.org/trac/ghc/wiki/Status/Encoding-Tickets) I identified some potential Unicode problems in Cabal install. The attached patch resolves them:

  1. Use wide (UTF-16) APIs to retrieve file paths
  1. Use withFilePath (from base) when marshalling a file path, as this will do the Right Thing when my changes are committed, though it is functionally equivalent to withCAString right now.

Patch attached.

Attachments

Cabal-Unicode.dpatch Download (38.4 KB) - added by batterseapower 2 years ago.

Change History

Changed 2 years ago by batterseapower

Changed 2 years ago by duncan

  • status changed from new to closed
  • resolution set to fixed

Applied thanks. 

Mon Apr 11 22:07:58 BST 2011  Max Bolingbroke <batterseapower@hotmail.com>
  * Unicode: use wide APIs on Windows and withFilePath on GHC

Changed 17 months ago by elga

*  virgin mobile

Note: See TracTickets for help on using tickets.